Add more unit test to cover code_pkcs11.c #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinglee-iot
force-pushed
the
update-core-pkcs11-unit-test
branch
from
5c7bdfa to
da9e3a8
Compare
chinglee-iot
commented
May 16, 2024
| } | ||
|
|
||
| if( xResult == CKR_OK ) | ||
| { | ||
| xResult = xInitializePKCS11(); | ||
| } | ||
| xResult = C_GetFunctionList( &pxFunctionList ); |
There was a problem hiding this comment.
Move C_GetFunctionList call here for CBMC check.
chinglee-iot
commented
May 16, 2024
| @@ -295,19 +275,30 @@ CK_RV xInitializePkcs11Session( CK_SESSION_HANDLE * pxSession ) | |||
| } | |||
|
|
|||
| /* Open a PKCS #11 session. */ | |||
| if( ( xResult == CKR_OK ) && ( pxSlotId != NULL ) && ( xSlotCount >= 1UL ) ) | |||
| if( ( xResult == CKR_OK ) && ( xSlotCount >= 1UL ) ) | |||
There was a problem hiding this comment.
( pxSlotId != NULL ) is a redundant check since the value xResult ensure this won't be NULL.
chinglee-iot
commented
May 16, 2024
| { | ||
| /* We will take the first slot available. | ||
| * If your application has multiple slots, insert logic | ||
| * for selecting an appropriate slot here. | ||
| */ | ||
| xResult = prvOpenSession( pxSession, pxSlotId[ 0 ] ); | ||
| if( pxFunctionList->C_OpenSession != NULL ) |
There was a problem hiding this comment.
Unwind prvOpenSession here to reuse the pxFunctionList
sirnish
approved these changes
May 16, 2024
aggarg
reviewed
May 16, 2024
|
|
||
| if( ulCalls == 3 ) | ||
| { | ||
| xResult = CKR_OK; |
There was a problem hiding this comment.
Will cover this in PR #196
aggarg
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more unit test to cover code_pkcs11.c
In this PR:
prvOpenSessionsince it is only used inxInitializePkcs11SessionandpxFunctionListis already obtained in this function.xInitializePkcs11Token.C_GetFunctionListcheckTest Steps
N/A
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.